Skip to content

Implement Clone for Client - #39

Merged
pinodeca merged 2 commits into
microsoft:mainfrom
alpinevm:main
Jul 29, 2026
Merged

Implement Clone for Client#39
pinodeca merged 2 commits into
microsoft:mainfrom
alpinevm:main

Conversation

@alpinevm

Copy link
Copy Markdown
Contributor

Summary

Client is documented as cloneable but did not implement Clone. Derive Clone so callers can cheaply duplicate a client while sharing the existing provider through its Arc.

Checklist

  • Tests added/updated
  • Regular tests pass locally (cargo nt)
  • Doc tests pass locally (cargo test --doc --all-features)
  • Docs updated
    • Existing docs updated where behavior changed
    • New doc added under docs/ if introducing a new area
    • Linked from docs/README.md

Links / Design notes

N/A

@pinodeca pinodeca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alpinevm, thanks for this contribution!

Since you allowed edits by maintainers, I went ahead and added a regression test.

@pinodeca
pinodeca merged commit c79d4f5 into microsoft:main Jul 29, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants